-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peakwise fit function for calibration peak fits #72
Conversation
From my side this looks fine. I let @verenaaur check again then we can merge! |
I don't think it should have an impact on the A/E functions |
Do we care about the tests failing or should this be merged now? |
Problem with tests is still the open bug tackled in the other PR |
So all open PRs are to be postponed until #73 fixes the failing tests? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #72 +/- ##
==========================================
+ Coverage 15.01% 15.24% +0.22%
==========================================
Files 33 33
Lines 2670 2676 +6
==========================================
+ Hits 401 408 +7
+ Misses 2269 2268 -1 ☔ View full report in Codecov by Sentry. |
We want to have different peakshapes for the escape peaks and maybe for other low-statistics peaks. That's why I made the following changes:
fit_peaks()
now also accepts a vector offit_func
.f_fit
,fit_func
, ...). If you feel creative and have better suggestions, feel free to write them below.Available fit functions:
gamma_def
: "default" gamma peakshape with gaussian signal, low-energy tail, and background (flat + step)gamma_tails
: default gamma peakshape + high-energy tailgamma_bckSlope
: default gamma peakshape + linear background slopegamma_bckExp
: default gamma peakshape + exponential backgroundgamma_bckFlat
: default gamma peakshape - step background (only flat component!)gamma_tails_bckFlat
: default gamma peakshape + high-energy tail - step background (only flat component!)Example: with escape peaks with high-energy tail but w/o Compton step
@theHenks we could write the
fit_func
for theth228_names
in jldataprod config, as we discussed. Any additional suggestions?@fhagemann, @verenaaur I don't think that the A/E functions have to be adapted to this change, right?